Skip to content

feat: add more logs to investigate tx broadcast issue #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 27, 2024

Conversation

0xmountaintop
Copy link

@0xmountaintop 0xmountaintop commented Aug 27, 2024

1. Purpose or design rationale of this PR

https://www.notion.so/scrollzkp/Investigate-tx-broadcast-issue-a6b9772c23384ad1ba2be4699f657d7a

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@0xmountaintop 0xmountaintop changed the base branch from syncUpstream/active to develop August 27, 2024 00:39
@0xmountaintop 0xmountaintop force-pushed the haoyu/investigate_broadcast branch 2 times, most recently from bfc44b6 to bb45a08 Compare August 27, 2024 04:09
@0xmountaintop 0xmountaintop marked this pull request as ready for review August 27, 2024 04:12
@0xmountaintop 0xmountaintop changed the title investigate broadcast part 1: log feat: add more logs to investigate tx broadcast issue Aug 27, 2024
@Thegaram Thegaram merged commit 77a5659 into develop Aug 27, 2024
8 checks passed
@Thegaram Thegaram deleted the haoyu/investigate_broadcast branch August 27, 2024 12:06
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Dec 16, 2024
* 1. broadcast + announce

* 2. broadcast

* 3. broadcast

* 5. announce

* 6. announce

* 7. announce

* 8. announce

* 9. announce

* 10. announce

* minor

* chore: auto version bump [bot]

---------

Co-authored-by: HAOYUatHZ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants