Skip to content

compatibility with Scala 2.13.1 #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

compatibility with Scala 2.13.1 #279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion scalac-scoverage-plugin/src/test/scala/scoverage/ScoverageCompiler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ object ScoverageCompiler {
}
}

// reporter should be a FilteringReporter in 2.13.1+, but using plain `Reporter` for cross-compiling
class ScoverageCompiler(settings: scala.tools.nsc.Settings, reporter: scala.tools.nsc.reporters.Reporter)
extends scala.tools.nsc.Global(settings, reporter) {

Expand Down Expand Up @@ -99,7 +100,9 @@ class ScoverageCompiler(settings: scala.tools.nsc.Settings, reporter: scala.tool
compileSourceFiles(urls.map(_.getFile).map(new File(_)): _*)
}

def assertNoErrors() = assert(!reporter.hasErrors, "There are compilation errors")
// (this: Global).reporter prevents an "ambiguous reference to overloaded definition" in 2.13.1+, where
// ScoverageCompiler.reporter is a Reporter, but Global.reporter is a more specific FilteringReporter
def assertNoErrors() = assert(!(this: Global).reporter.hasErrors, "There are compilation errors")

def assertNoCoverage() = assert(!testStore.sources.mkString(" ").contains(s"scoverage.Invoker.invoked"),
"There are scoverage.Invoker.invoked instructions added to the code")
Expand Down