Skip to content
This repository was archived by the owner on Dec 6, 2023. It is now read-only.

update examples and docs config to be compatible with current Python #171

Merged
merged 4 commits into from
May 13, 2021
Merged

Conversation

StrikerRUS
Copy link
Contributor

@StrikerRUS StrikerRUS commented May 10, 2021

Refer to #172 (comment) and #172 (comment).

Now docs (with examples gallery) can be generated with the current version of Python, Sphinx and other required software.

Here is the compiled result after executing make html.

_build.zip

@@ -21,7 +21,7 @@
import numpy as np
import matplotlib.pyplot as plt
from lightning.classification import FistaClassifier
from sklearn.grid_search import GridSearchCV
from sklearn.model_selection import GridSearchCV
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -31,11 +31,11 @@ def __init__(self, X, y):
self.y = y
self.obj = []
self.times = []
self.start_time = time.clock()
self.start_time = time.time()
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecated since version 3.3, will be removed in version 3.8:
https://docs.python.org/3.7/library/time.html#time.clock

Comment on lines +1 to 3
.navbar-text {
display: none !important;
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the purpose of adding this rule?

@StrikerRUS
Copy link
Contributor Author

@mblondel @vene
Thanks for your time and consideration!

@mblondel mblondel merged commit ec4d6a3 into scikit-learn-contrib:master May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants