Edit doc to comply with the go one #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasscw
commented
Mar 2, 2023
cyclimse
reviewed
Mar 2, 2023
README.md
Outdated
|
|
||
| ## 🎓 Contributing | ||
|
|
||
| We welcome all contributions to our open-source projects, please see our [contributing guidelines](.github/CONTRIBUTING.md). | ||
| We welcome all contributions to our open-source projects, please see our contributing guidelines <link>. |
There was a problem hiding this comment.
Suggested change
| We welcome all contributions to our open-source projects, please see our contributing guidelines <link>. | |
| We welcome all contributions to our open-source projects, please see our contributing guidelines [contributing guidelines](.github/CONTRIBUTING.md). |
cyclimse
reviewed
Mar 2, 2023
README.md
Outdated
Comment on lines
96
to
99
| ## 🧑💻 Development | ||
|
|
||
| This repository is at its early stage and is still in active development. | ||
| If you are looking for a way to contribute please read [CONTRIBUTING.md](./docs/CONTRIBUTING.md). |
There was a problem hiding this comment.
TBH, I think this section is too similar to the Contributing section
cyclimse
reviewed
Mar 2, 2023
README.md
Outdated
Comment on lines
64
to
117
| We love feedback. Feel free to: | ||
|
|
||
| - Open a [Github issue](https://github.com/scaleway/serverless-functions-python/issues/new) | ||
| - Send us a message on the [Scaleway Slack community](https://slack.scaleway.com/), in the [#serverless-functions](https://scaleway-community.slack.com/app_redirect?channel=serverless-functions) channel. | ||
| We love feedback. | ||
| Don't hesitate to open a [Github issue](https://github.com/scaleway/serverless-functions/go/issues/new) or | ||
| feel free to reach us on [Scaleway Slack community](https://slack.scaleway.com/), | ||
| we are waiting for you on [#serverless-functions](https://scaleway-community.slack.com/app_redirect?channel=serverless-functions). |
There was a problem hiding this comment.
This differs based on the feedback from Simon: #1 (comment)
thomas-tacquet
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What's changed?
Why do we need this?
How have you tested it?
Checklist
Details