Fix #6697: Ingore bounds checks in match type patterns #7214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
approved these changes
Sep 26, 2019
| @@ -306,6 +306,15 @@ class PostTyper extends MacroTransform with IdentityDenotTransformer { thisPhase | |||
| // case x: Tree[?] | |||
| // (which translates to) | |||
| // case x: (_: Tree[?]) | |||
| case m @ MatchTypeTree(bounds, selector, cases) => | |||
| // Analog to the case above for match types | |||
| def ignoreBoundsCheck(x: CaseDef): CaseDef = | |||
There was a problem hiding this comment.
transformWithoutBoundsCheck or tranformIgnoringBoundsCheck maybe?
Similarly to what's done for values when we write `case _: F[x]`, there is no need to check that `x` conforms to its bounds as we are currently binding it.
OlivierBlanvillain
force-pushed
the
fix-6697
branch
from
f745041 to
79e232d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similarly to what's done for values when we write
case _: F[x], there is no need to check thatxconforms to its bounds as we are currently binding it.