Fix "sbt console" in Scala 2 projects when sbt-dotty is in the build #6577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
reviewed
May 29, 2019
See scala/scala-xml#313 for example. No test because apparently there's no way to properly test "sbt console" from scripted tests: https://github.com/sbt/sbt/blob/b6f02b9b8cd0abb15e3d8856fd76b570deb1bd61/sbt/src/sbt-test/project/console/test#L7
smarter
force-pushed
the
sbt-dotty-interference
branch
from
300e0e7 to
d46235b
Compare
smarter
added a commit
to smarter/scala-xml
that referenced
this pull request
May 29, 2019
This includes scala/scala3#6577 which fixes "sbt console" in Scala 2 projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See scala/scala-xml#313 for example.
No test because apparently there's no way to properly test "sbt console"
from scripted tests:
https://github.com/sbt/sbt/blob/b6f02b9b8cd0abb15e3d8856fd76b570deb1bd61/sbt/src/sbt-test/project/console/test#L7