Skip to content

Add debug string to assertion error message. #2801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2017
Merged

Add debug string to assertion error message. #2801

merged 1 commit into from
Jun 24, 2017

Conversation

olafurpg
Copy link
Contributor

This commit changes the assertion error messaage in #2797 from an empty
message to:

found:    Array[java.nio.file.FileVisitOption]
[error] required: java.nio.file.FileVisitOption

@olafurpg olafurpg requested a review from odersky June 23, 2017 17:45
Copy link
Member

@dottybot dottybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, and thank you for opening this PR! 🎉

All contributors have signed the CLA, thank you! ❤️

Commit Messages

We want to keep history, but for that to actually be useful we have
some rules on how to format our commit messages (relevant xkcd).

Please stick to these guidelines for commit messages:

  1. Separate subject from body with a blank line
  2. When fixing an issue, start your commit message with Fix #<ISSUE-NBR>:
  3. Limit the subject line to 72 characters
  4. Capitalize the subject line
  5. Do not end the subject line with a period
  6. Use the imperative mood in the subject line ("Added" instead of "Add")
  7. Wrap the body at 80 characters
  8. Use the body to explain what and why vs. how

adapted from https://chris.beams.io/posts/git-commit

Have an awesome day! ☀️

This commit changes the assertion error messaage in #2797 from an empty
message to:
```
found:    Array[java.nio.file.FileVisitOption]
[error] required: java.nio.file.FileVisitOption
```
@odersky
Copy link
Contributor

odersky commented Jun 24, 2017

LGTM

@odersky odersky merged commit 1a959c3 into scala:master Jun 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants