Fix completion mode filtering + optimize scopeCompletions #23172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochala
commented
May 15, 2025
|
|
||
| // There are four possible ways for an extension method to be applicable | ||
|
|
||
| // 1. The extension method is visible under a simple name, by being defined or inherited or imported in a scope enclosing the reference. | ||
| val termCompleter = new Completer(Mode.Term, pos, untpdPath, matches) | ||
| val extMethodsInScope = termCompleter.scopeCompletions.names.toList.flatMap: |
There was a problem hiding this comment.
Actual fix, I was also thinking about adding
case d: SymDenotation if d.isTerm && d.termRef.symbol.is(Extension) && include(d, name)but the issue was actually the whole creation of new completer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've changed scopeCompletions to lazy val to memoize because I beliveve we don't need to recompute it. The actual fix is at the comment. There is no need to create a new Completer just to filter all of remaining completions at later stage.
Fixes #23150