Skip to content

Fix inductive-implicits benchmark #22007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Fix inductive-implicits benchmark #22007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7653e85
Delete duplicate inductive-implicits test
mbovel Nov 22, 2024
d3b9d76
Comment out 35 more lines in inductive-implicits
mbovel Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 38 additions & 38 deletions tests/bench/inductive-implicits.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,49 +174,49 @@ object Test extends App {
Int ::
Int ::
//
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
//
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
//
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
Int ::
//
Int ::
Int ::
Int ::
Int ::
Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// //
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// //
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// //
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// Int ::
// //
// Int ::
// Int ::
Expand Down
127 changes: 0 additions & 127 deletions tests/pos-deep-subtype/inductive-implicits-bench.scala
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This technically removes a test. Yes, the content is similar, but it is executed under different conditions:

scala3/compiler/test/dotty/tools/dotc/CompilationTests.scala

Line 36 in f8159a3

compileFilesInDir("tests/pos-deep-subtype", allowDeepSubtypes),

Are you removing it just because of duplicate content ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bench test has similar flags:

scala3/compiler/test/dotty/tools/dotc/BootstrappedOnlyCompilationTests.scala

Line 30 in f8159a3

compileFilesInDir("tests/bench", defaultOptions.without("-Yno-deep-subtypes")),

One is bootstrapped and the other not, but I don't think it's relevant for this test: keeping the bootstrapped version should be enough, as for the other bench tests.

Copy link
Member

@hamzaremmal hamzaremmal Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaah, I got confused about what flags were enabled in both cases 😅

This file was deleted.

Loading