Regression test for extension nullification, nowarn for different opacities #21191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ichoran
reviewed
Jul 14, 2024
som-snytt
force-pushed
the
issue/21190-opaque-overwarning
branch
from
10f9c36 to
67a2534
Compare
som-snytt
changed the title
| @@ -0,0 +1,23 @@ | |||
|
|
|||
| //> using options -Werror | |||
There was a problem hiding this comment.
-Werror isn't needed here, warn tests will fail if an error is reported in an unspecified location.
There was a problem hiding this comment.
It's a way to say "expect no warnings" without scanning the source visually or grepping.
There was a problem hiding this comment.
Ok, that sounds like a good practice actually. 😅
KacperFKorban
approved these changes
Feb 28, 2025
tgodzik
pushed a commit
to scala/scala3-lts
that referenced
this pull request
Apr 23, 2025
…cities (scala#21191) Fixes scala#21190 ~Adjust~ test that params must not be of different opacity ~opaque~. ~Other aliases are permitted, but could check if they are effectively final. String alias can't be overridden.~ The tweak was scala#22268 and the ticket was a duplicate. In the meantime, it also doesn't warn for any override, so the previous concern about aliases doesn't apply. [Cherry-picked ee62b32]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21190
Adjusttest that params must not be of different opacityopaque.Other aliases are permitted, but could check if they are effectively final. String alias can't be overridden.The tweak was #22268 and the ticket was a duplicate. In the meantime, it also doesn't warn for any override, so the previous concern about aliases doesn't apply.