Refinements to auto-tupling #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a nasty interaction with auto-tupling and trying to insert an implicit on the qualifier of a call. If the original call fails, we need to "undo" any auto-tupling decisions in calls where an implicit is inserted on the qualifier. Also: Needed to fix canAutoTuple test so that Scala2 feature is checked instead of dotty's. Also: Drop features in dotty.language that duplicate those in scala.language.
- Delete redundant t2660 (exists elready in pos) - Comment t1756 - Recategorize tryexpr
Needed because the test is also run in neg wihtout command line option.
| /** Keep union types */ | ||
| val keepUnions = new Feature | ||
|
|
||
| /** No auto tupling */ | ||
| val noAutoTupling = new Feature | ||
| val f = "".contains("", (_: Int)) |
There was a problem hiding this comment.
I don't think that was an intentional change
| } else typedApply( | ||
| cpy.Apply(tree)(untpd.TypedSplice(fun2), proto.typedArgs map untpd.TypedSplice), pt) | ||
| } | ||
| def fail = { failedState.commit(); failedVal } |
There was a problem hiding this comment.
Should be def fail() since it's not pure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a nasty interaction with implicit search ion qualifiers.