Fix Reflection wildcard abstraction #13154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
reviewed
Jul 26, 2021
| extension (self: Typed) | ||
| def tree: Tree = self.expr | ||
| def tpt: TypeTree = self.tpt | ||
| end extension |
There was a problem hiding this comment.
mere style question whether the "double end" is desirable? Arguably, both ends on a very short definition? It comes up on the forum and folks look at this source for style guidance. Maybe we need an influencer on twitter to offer style advice.
There was a problem hiding this comment.
Not sure about the general desirability of the "double end". It mostly came from copy-pasting other uses. I used regex find and replace in this file a lot, the explicit end is sometimes useful for that.
I would say the "double end" is useful when we have a large number of extension methods. In that case it makes it easier to see that all the methods are extension methods.
Currently, we are missing in the API the Wildcard concept for `case _ =>` patterns. These are encoded as term `Ident` with name `_`. This tree can be inconsistently matched by `Ident`, `TypeIdent` or `WildcardTypeTree`. There is also no way to create an `Ident(_)`. The typed expression can contain non-Term trees: Wildcard, Alternatives, Bind and Unapply. The solution is to add a TypedTree supertype of Typed that contains a Tree. Changes * `WildcardTypeTree` does not match `Ident(_)` if it is a term * Add `Wildcard` type that matches a term `Ident(_)` * `Typed` only matched if the expr is a `Term` * Add `TypedTree` Partial fix of scala#12188
nicolasstucki
force-pushed
the
add-refelct-wildcard
branch
from
2a57ee1 to
fb9d75f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we are missing in the API the Wildcard concept for
case _ =>patterns.These are encoded as term
Identwith name_. This tree can be inconsistentlymatched by
Ident,TypeIdentorWildcardTypeTree. There is also no way to create anIdent(_).The typed expression can contain non-Term trees: Wildcard, Alternatives, Bind and Unapply.
The solution is to add a TypedTree supertype of Typed that contains a Tree.
Changes
WildcardTypeTreedoes not matchIdent(_)if it is a termWildcardtype that matches a termIdent(_)Typedonly matched if the expr is aTermTypedTreePartial fix of #12188 (rest of the fix in #12200)