Fix #12249: don't export java defined modules #12516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBlanvillain
changed the title
OlivierBlanvillain
force-pushed
the
fix-12249
branch
from
18758bb to
a8bf3e9
Compare
smarter
reviewed
May 18, 2021
| @@ -1000,6 +1000,8 @@ class Namer { typer: Typer => | |||
| ) match | |||
| case Some(other) => No(i"overrides ${other.showLocated}, which is already a member of $cls") | |||
| case None => Yes | |||
| else if sym.is(JavaDefined) then | |||
There was a problem hiding this comment.
I think the issue comes from trying to export a Java class because we're missing code for exporting the static methods of the class but we shouldn't prevent exporting a Java method
OlivierBlanvillain
force-pushed
the
fix-12249
branch
from
a8bf3e9 to
1ae6466
Compare
smarter
requested changes
May 19, 2021
| @@ -1000,6 +1000,8 @@ class Namer { typer: Typer => | |||
| ) match | |||
| case Some(other) => No(i"overrides ${other.showLocated}, which is already a member of $cls") | |||
| case None => Yes | |||
| else if sym.is(JavaDefined) && sym.is(Module) then | |||
There was a problem hiding this comment.
Suggested change
| else if sym.is(JavaDefined) && sym.is(Module) then | |
| else if sym.is(JavaModule) then |
OlivierBlanvillain
force-pushed
the
fix-12249
branch
from
1ae6466 to
0c4c119
Compare
OlivierBlanvillain
changed the title
smarter
approved these changes
May 19, 2021
OlivierBlanvillain
force-pushed
the
fix-12249
branch
from
0c4c119 to
070b863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.