Skip to content

Fix source links for stdlib #12319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2021

Conversation

BarkingBad
Copy link
Contributor

We should really merge tests for source links to prevent further regressions #11512

@BarkingBad BarkingBad requested a review from pikinier20 May 4, 2021 09:26
@BarkingBad BarkingBad force-pushed the scaladoc/fix-sourcelinks branch from 5b7fc8f to 4f6545b Compare May 4, 2021 10:04
@BarkingBad BarkingBad marked this pull request as draft May 4, 2021 10:04
@BarkingBad BarkingBad force-pushed the scaladoc/fix-sourcelinks branch 2 times, most recently from 6d62647 to 0b2ff04 Compare May 4, 2021 13:10
@@ -4,6 +4,8 @@ import java.nio.file.{Path, Paths}

case class PathBased[T](entries: List[PathBased.Entry[T]], projectRoot: Path):
def get(path: Path): Option[PathBased.Result[T]] =
println(path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

debugging leftovers

@BarkingBad BarkingBad force-pushed the scaladoc/fix-sourcelinks branch 2 times, most recently from 544874c to ef742d3 Compare May 4, 2021 14:44
@BarkingBad BarkingBad force-pushed the scaladoc/fix-sourcelinks branch from ef742d3 to ccf33ce Compare May 4, 2021 15:38
@BarkingBad BarkingBad marked this pull request as ready for review May 4, 2021 15:42
@BarkingBad BarkingBad requested a review from romanowski May 4, 2021 15:42
@BarkingBad BarkingBad merged commit d81b0e5 into scala:master May 4, 2021
@BarkingBad BarkingBad deleted the scaladoc/fix-sourcelinks branch May 4, 2021 16:48
@Kordyjan Kordyjan added this to the 3.0.1 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants