Skip to content

Implement following of local label DefDefs in tailrec #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DarkDimius opened this issue Oct 16, 2014 · 1 comment
Closed

Implement following of local label DefDefs in tailrec #194

DarkDimius opened this issue Oct 16, 2014 · 1 comment
Labels
itype:enhancement prio:low

Comments

@DarkDimius
Copy link
Contributor

Would allow to group tailrec and patmat into the same phase.
@DarkDimius DarkDimius changed the title Implement following of local label DefDef's in tailrec Implement following of local label DefDefs in tailrec Oct 16, 2014
DarkDimius added a commit to dotty-staging/dotty that referenced this issue Oct 22, 2014
@DarkDimius
Fix scala#196. Errorneus tail-optimization of inner DefDef's
f234735 
Unless a DefDef is a result of desugaring an exception handler it shouldn't be optimized by tailrec.

There's a potential improvement here: to detect that a DefDef
 is a label def which itself is called only in tail position.

 This is a requirement to implement scala#194
DarkDimius added a commit to dotty-staging/dotty that referenced this issue Oct 22, 2014
@DarkDimius
Fix scala#196. Errorneus tail-optimization of inner DefDef's
ddf57c9 
Unless a DefDef is a result of desugaring an exception handler it shouldn't be optimized by tailrec.

There's a potential improvement here: to detect that a DefDef
 is a label def which itself is called only in tail position.

 This is a requirement to implement scala#194
@DarkDimius DarkDimius mentioned this issue Oct 22, 2014
Merged
@DarkDimius
Copy link
Contributor Author

I'm not going to work on this any time soon and this is low priority.

@DarkDimius DarkDimius removed their assignment Nov 18, 2015
@odersky odersky closed this as completed Jan 27, 2018
WojciechMazur pushed a commit to WojciechMazur/dotty that referenced this issue May 8, 2025
@tgodzik
Merge pull request scala#194 from scala/backport-lts-3.3-22407
0e94367 
Backport "Fix mapping of annotations" to 3.3 LTS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
itype:enhancement prio:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odersky @DarkDimius