Skip to content

Backport "Avoid erasure/preErasure issues around Any in transformIsInstanceOf" to 3.3 LTS #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 16, 2025
Merged

Backport "Avoid erasure/preErasure issues around Any in transformIsInstanceOf" to 3.3 LTS #73

merged 3 commits into from
Feb 16, 2025

Conversation

tgodzik
Copy link

@tgodzik tgodzik commented Feb 14, 2025

Backports scala#21647 to the 3.3.6.

PR submitted by the release tooling.
[skip ci]

@dwijnand @tgodzik
Avoid erasure/preErasure issues around Any in transformIsInstanceOf
b611bca 
The testType Any is erased to Object, but the expr type Int isn't erased
to Integer, so then it fails as Int !<: Object.  We avoid the problem by
feeding in AnyVal, leading to a (possibly elided) non-null test only.

[Cherry-picked d02d4b8]
@dwijnand @tgodzik
Simplify transformIsInstanceOf check
6935251 
[Cherry-picked 7b721f0]
@dwijnand @tgodzik
Add extra isInstanceOf test cases
aea7d9e 
[Cherry-picked 49d876a]
Base automatically changed from backport-lts-3.3-21876 to lts-3.3 February 16, 2025 19:38
@tgodzik
Copy link
Author

tgodzik commented Feb 16, 2025

No regressions detected in the community build up to backport-lts-3.3-21887.

Reference

@tgodzik tgodzik merged commit b6336cd into lts-3.3 Feb 16, 2025
22 checks passed
@tgodzik tgodzik deleted the backport-lts-3.3-21647 branch February 16, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgodzik @dwijnand