Skip to content

Add JDK 15/16 To The CircleCI Build #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2020
Merged

Add JDK 15/16 To The CircleCI Build #451

merged 1 commit into from
Nov 30, 2020

Conversation

isomarcte
Copy link
Contributor

@isomarcte isomarcte commented Sep 20, 2020 •
edited
Loading

Though JDK16 is not yet released, building with it now will give us warnings about issues such as failure to build on JDK15 (#450)

Also adds the osgiBundle task to CI to catch issues with it.

@isomarcte
Copy link
Contributor Author

Note: This will fail on JDK15/16 until #450 is merged.

@isomarcte
Copy link
Contributor Author

At least, it will if it runs the xml/osgiBundle SBT Task. I'm actually unsure if the CI build does that...

@isomarcte
Copy link
Contributor Author

I should mention, this also bumps the other JDK minor versions by using the default tags in circle ci.

@isomarcte
Copy link
Contributor Author

Apparently it doesn't run osgiBundle. I've updated the CI to run that now.

@SethTisue
Copy link
Member

Though JDK16 is not yet released, building with it now will give us warnings about issues such as failure to build on JDK15 (#450)

👍, and also scala/community-build#1225 should help shake out this kind of thing

@SethTisue SethTisue self-assigned this Sep 29, 2020
@SethTisue SethTisue marked this pull request as draft September 29, 2020 18:44
@SethTisue
Copy link
Member

Apparently it doesn't run osgiBundle. I've updated the CI to run that now

I added a commit doing the same for Travis-CI. (It's unclear if we'll keep both CIs indefinitely.)

@SethTisue SethTisue marked this pull request as ready for review September 30, 2020 20:31
@SethTisue SethTisue requested a review from ashawley September 30, 2020 20:41
@SethTisue SethTisue removed their assignment Sep 30, 2020
@SethTisue
Copy link
Member

@isomarcte I forgot about this PR. if you rebase and update it (after #470 is merged), I'll merge it

before noticing this PR, I made some of the same changes in #470, but only some of them.

@isomarcte
Add JDK 16 To The CircleCI Build
49486a3 
Though JDK16 is not yet released, building with it now will give us warnings about issues such as failure to build on JDK15 (scala#450)

Also adds the `osgiBundle` task to CI to catch issues with it.
@isomarcte
Copy link
Contributor Author

@SethTisue updated.

@SethTisue SethTisue merged commit ed1a21e into scala:master Nov 30, 2020
@SethTisue
Copy link
Member

super, thank you!

@isomarcte isomarcte deleted the jdk15-ci branch December 1, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashawley ashawley Awaiting requested review from ashawley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isomarcte @SethTisue