Dotty 3.0.0-M1 support #124
Conversation
- RichWindow - we cannot override internal class InterfaceMixin, thus
introduce InterfaceMixin2
- ScrollPane.BarPolicy cannot be an Enumeration because we cannot
override internal class Value. Make it a case class instead
- Window#SuperMixin causes a compiler bug in Dotty
("dotc: wrong number of arguments at crossCast for (x$0: java.awt.GraphicsConfiguration): java.awt.Window: (java.awt.Window#<init> : (x$0: java.awt.GraphicsConfiguration): java.awt.Window
), expected: 1, found: 0"
- we're waiting for scala-test
- Action.Trigger.Wrapper, Oriented.Wrapper, Orientable.Wrapper have been removed; one must mix in Action.Trigger, Oriented, Orientable instead and implement the methods - Swing.PeerContainer is not a structural type but a trait, that must be mixed in - clean up some examples - remove lanuage feature lazy vals from package object
| @@ -16,6 +16,6 @@ package scala.swing | |||
| * A frame that can be used for main application windows. It shuts down the | |||
| * framework and quits the application when closed. | |||
| */ | |||
| class MainFrame(gc: java.awt.GraphicsConfiguration = null) extends Frame(gc) { | |||
| class MainFrame(/*gc: java.awt.GraphicsConfiguration = null*/) extends Frame /*(gc)*/ { | |||
There was a problem hiding this comment.
might have missed to undo this? will check
| @@ -79,7 +79,7 @@ private[swing] trait LazyPublisher extends Publisher { | |||
|
|
|||
| import scala.ref._ | |||
|
|
|||
| private[swing] trait SingleRefCollection[+A <: AnyRef] extends Iterable[A] { self => | |||
| private[swing] trait SingleRefCollection[/*+*/ A <: AnyRef] extends Iterable[A] { self => | |||
There was a problem hiding this comment.
No, this is stronger enforcement by dotty. Just remove the entire commented part.
- build with 2.11, 2.12, 2.13, 3.0.0-M1 - update travis - update readme - restore MainFrame constructor argument - remove unused import
|
Ok tests with all cross scala versions. The indended new version of scala-swing will be 2.2.0. |
@Sciss I think this should be 3.0.0 then, not 2.2.0? |
|
Are we not in "old style" semver, like |
|
In general in the Scala modules we use major.minor.patch. Bump patch if bugfix only; bump minor when breaking forward compat; bump major when breaking backward compat. So yeah, I would prefer we call it 3.0.0 unless you have a strong opinion otherwise. |
|
Oh, alright. Then I will just edit the README. |
No description provided.