ScalaTest 3.2 #1172

SethTisue · 2020-06-25T19:54:40Z

I don't know if this will be mergeable, but I want to at least see what happens

SethTisue · 2020-06-26T01:16:21Z

SUCCEEDED: 104, but FAILURES (UNEXPECTED): discipline-scalatest,silencer,scalameta,log4s,cachecontrol,sbt-io,squants,jwt-scala,grizzled,sksamuel-exts,scalariform,perfolation,twotails,scoverage,scapegoat,scalatest-tests,scala-typed-holes,scala-swing,scala-records,pascal

BLOCKING DOWNSTREAM: discipline-scalatest (61), silencer (45), scalameta (11), log4s (9), cachecontrol (4), sbt-io (3), squants (2), jwt-scala (2), grizzled (2), sksamuel-exts (1), scalariform (1), perfolation (1)

so far I only glanced at a few of the failures, it looked like they are running afoul of 3.2 removing deprecated stuff

I'd have to look, but it's possible that some of the failed projects are actually still declaring a 3.0 dependency, but happened to be only using APIs that remained source-compatible in 3.1

SethTisue · 2020-07-01T06:06:55Z

nice

https://scala-ci.typesafe.com/view/scala-2.13.x/job/scala-2.13.x-jdk11-integrate-community-build/1586/console

SUCCEEDED: 142

BLOCKING DOWNSTREAM: fs2 (14), better-monadic-for (14), scalameta (11), log4s (9), paiges (8), akka-http (8), enumeratum (5), cachecontrol (4), sbt-io (3), mockito-scala (3), squants (2), sjson-new (2), jwt-scala (2), grizzled (2), sksamuel-exts (1), scalariform (1), akka-persistence-jdbc (1), perfolation (1), circe-config (1), akka-persistence-cassandra (1)

SethTisue · 2020-07-02T01:02:56Z

fs2 we currently have frozen at v2.1.0, which pureconfig downstream expects

fs2 moved to newer ScalaTest starting with v2.3.0 (and at the moment the newest tag is v2.4.2)

so probably the next step here would be: try moving to fs2 v2.4.2; see what breaks; if only pureconfig breaks, open an issue requesting that they upgrade (or attempt the upgrade myself if it seems easy/quick enough); if a bunch of stuff breaks, reconsider

see also typelevel/fs2#1778 for background on the ScalaTest situation in the fs2 repo

oh and scalatest/scalatest#1735 (comment), sigh

SethTisue · 2020-07-07T14:05:42Z

some of the failing projects declare a dependency on ScalaTest 3.0, but happened to be source-compatible with 3.1 as well, but not with 3.2. those projects can be fixed by downgrading them to 3.0, instead of moving them forward to 3.2

SethTisue · 2020-07-23T23:34:25Z

ah, I think scalamock is failing because it's getting both ScalaTest 3.0 and 3.2 on the classpath:

sbt:newdir> show scalamockJVM/Test/dependencyClasspath
...
[info] * Attributed(/Users/tisue/community.213/newdir/.dbuild/local-repo/0/org/scalatest/scalatest/0.1.0-dbuildx844a130f65c0a2aec1f6e1bc54f290613ceb82a5/scalatest-0.1.0-dbuildx844a130f65c0a2aec1f6e1bc54f290613ceb82a5.jar)
..
[info] * Attributed(/Users/tisue/community.213/newdir/.dbuild/local-repo/0/scalacommunitybuild/scalatest/3.0.8-dbuildx5357ef16b53db397b4d7bf413e496c45c35ccaaa/scalatest-3.0.8-dbuildx5357ef16b53db397b4d7bf413e496c45c35ccaaa.jar)
...

SethTisue · 2020-07-24T05:28:14Z

success is tantalizingly near: SUCCEEDED: 213; FAILURES (UNEXPECTED): circe-config,akka-persistence-jdbc,akka-management,scalatest-tests; FAILED: 4; BLOCKED, DID NOT RUN: 2

SethTisue · 2020-07-24T20:29:28Z

I thought adding this to scalatest.conf might fix circe-config:

+  set-version: "3.2.0"  // because https://github.com/tkawachi/sbt-doctest/issues/135 affects circe-config

but I've never used set-version before and it didn't seem to have any effect:

[circe-config] All Dependencies for subproject default-sbt-project:
...
[circe-config]    org.scalatest:scalatest:0.1.0-dbuildx844a130f65c0a2aec1f6e1bc54f290613ceb82a5:test
...

I'd hoped the 0.1.0-dbuildx844... would be 3.2.0-dbuildx844... (or 3.2.0, I guess)

SethTisue · 2020-07-24T20:37:23Z

for circe-config, I'm just gonna dodge the issue with:

+  // (July 2020) this is a bit sad, but I don't see a way to work around
+  // https://github.com/tkawachi/sbt-doctest/issues/135
+  extra.run-tests: false

SethTisue · 2020-07-24T21:09:13Z

the scalatest-tests thing is reproducible outside of dbuild simply by running genSortedTests/test in the ScalaTest repo

the filename seems to vary, on second run I saw:

[error] (genSortedTests / Test / managedSources) java.io.FileNotFoundException: scalatest-test/src/test/scala/org/scalatest/ShouldBeSortedLogicalAndSpec.scala (No such file or directory)

SethTisue · 2020-07-24T22:37:18Z

I think I'm just going to remove scalatest-tests from the build, for now anyway. perhaps I'll get some guidance over at scalatest/scalatest#1851 and/or scalatest/scalatest#1852 on what I would need to do to run the tests without all the complexity that I see in that repo's .travis.yml and travis_build.sh. it's complexity I can't really afford to get involved in

SethTisue · 2020-07-24T22:54:32Z

🎉

SethTisue · 2020-07-26T14:28:20Z

attempting to reinstate scalatest-tests: #1190

wip

77eac3e

SethTisue self-assigned this Jun 25, 2020

SethTisue added the contents label Jun 25, 2020

SethTisue added 3 commits June 25, 2020 14:18

wip

d7ec921

wip

a6d102f

wip

8cb3fb3

This comment has been minimized.

Sign in to view

SethTisue added 3 commits June 30, 2020 18:07

wip

5c1b248

wip

00d55ce

wip

64c0b69

wip

ff27ef1

SethTisue mentioned this pull request Jul 2, 2020

upgrade to ScalaTest 3.1 oleg-py/better-monadic-for#46

Merged

This comment has been minimized.

Sign in to view

SethTisue added 9 commits July 1, 2020 18:13

Merge remote-tracking branch 'origin/2.13.x' into scalatest-3.2

3120124

Merge remote-tracking branch 'origin/2.13.x' into scalatest-3.2

a61472c

wip

8e7828f

wip

e3331fa

Merge remote-tracking branch 'origin/2.13.x' into scalatest-3.2

2967c2e

wip

82bd3d8

wip

8ca8927

wip

cc8779e

wip

78a749b

SethTisue added 3 commits July 7, 2020 09:20

wip

d918873

wip

2e62b01

wip

5439e50

SethTisue added 2 commits July 23, 2020 18:32

wip

f76390a

wip

dd4f2de

SethTisue mentioned this pull request Jul 24, 2020

upgrade ScalaTest and spire; drop 2.11 support to-ithaca/libra#121

Merged

SethTisue added 7 commits July 23, 2020 19:07

wip

763560d

wip

96c4948

wip

5b89c97

Merge remote-tracking branch 'origin/2.13.x' into scalatest-3.2

ec21c4d

wip

fc67955

wip

ba6218c

wip

ab58c3e

SethTisue added 2 commits July 24, 2020 08:33

wip

b532579

wip

3fe9f65

wip

8ce1bc2

SethTisue mentioned this pull request Jul 24, 2020

genSortedTests fails with FileNotFoundException on 3.2.x-new branch scalatest/scalatest#1851

Closed

SethTisue added 2 commits July 24, 2020 14:27

wip

322b04b

wip

6a4a14a

SethTisue mentioned this pull request Jul 24, 2020

genRegularTests4 fails (order-dependent) scalatest/scalatest#1852

Open

wip

4f70104

wip

557c3a8

SethTisue marked this pull request as ready for review July 24, 2020 22:53

SethTisue merged commit 73f680e into scala:2.13.x Jul 24, 2020

SethTisue deleted the scalatest-3.2 branch July 24, 2020 22:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

ScalaTest 3.2 #1172

ScalaTest 3.2 #1172

Uh oh!

SethTisue commented Jun 25, 2020 •

edited

Loading

Uh oh!

SethTisue commented Jun 26, 2020 •

edited

Loading

Uh oh!

This comment has been minimized.

This comment has been minimized.

SethTisue commented Jul 1, 2020 •

edited

Loading

Uh oh!

SethTisue commented Jul 2, 2020 •

edited

Loading

Uh oh!

This comment has been minimized.

SethTisue commented Jul 7, 2020

Uh oh!

SethTisue commented Jul 23, 2020

Uh oh!

SethTisue commented Jul 24, 2020

Uh oh!

SethTisue commented Jul 24, 2020

Uh oh!

SethTisue commented Jul 24, 2020 •

edited

Loading

Uh oh!

SethTisue commented Jul 24, 2020 •

edited

Loading

Uh oh!

SethTisue commented Jul 24, 2020

Uh oh!

SethTisue commented Jul 24, 2020

Uh oh!

SethTisue commented Jul 26, 2020

Uh oh!

Uh oh!

ScalaTest 3.2 #1172

ScalaTest 3.2 #1172

Uh oh!

Conversation

SethTisue commented Jun 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SethTisue commented Jun 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

SethTisue commented Jul 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SethTisue commented Jul 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

SethTisue commented Jul 7, 2020

Uh oh!

SethTisue commented Jul 23, 2020

Uh oh!

SethTisue commented Jul 24, 2020

Uh oh!

SethTisue commented Jul 24, 2020

Uh oh!

SethTisue commented Jul 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SethTisue commented Jul 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SethTisue commented Jul 24, 2020

Uh oh!

SethTisue commented Jul 24, 2020

Uh oh!

SethTisue commented Jul 26, 2020

Uh oh!

Uh oh!

SethTisue commented Jun 25, 2020 •

edited

Loading

SethTisue commented Jun 26, 2020 •

edited

Loading

SethTisue commented Jul 1, 2020 •

edited

Loading

SethTisue commented Jul 2, 2020 •

edited

Loading

SethTisue commented Jul 24, 2020 •

edited

Loading

SethTisue commented Jul 24, 2020 •

edited

Loading