Skip to content

Adds stylemedia back #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2021
Merged

Adds stylemedia back #113

merged 3 commits into from
Jul 1, 2021

Conversation

orta
Copy link

@orta orta commented Jun 24, 2021

StyleMedia is used in React's types

@saschanaz
Copy link
Owner

saschanaz commented Jun 24, 2021

I'm not sure why it's used and for what. It doesn't exist anywhere. If it only uses the type but not the value, maybe noInterfaceObject: true and deprecated?

@saschanaz
Copy link
Owner

saschanaz commented Jun 25, 2021

Just took a look at React types. It's used in interface AbstractView which seems to be mocking window with only two properties. Since window.styleMedia only existed in IE11 and nowhere else, it should not exist there. And it only uses the type, so I guess #113 (comment) should be acceptable.

@orta
Copy link
Author

orta commented Jul 1, 2021

OK, this is rebased, commented and updated with feedback

@saschanaz saschanaz merged commit d384b28 into saschanaz:main Jul 1, 2021
@saschanaz
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants