Remove the readonly attribute on all prototype #109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very unfortunate, but LGTM. Could you add some more comment why it had to be rolled back? |
…_readonly_prototype
…lib-generator into de_readonly_prototype
|
perfect candidate for a squash commit ;) |
|
Actually all commits are squashed in my fork 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, when someone sends a type through enough transformation - the
readonlycan get lost. This can mean when that the two versions of the same thing to not be the same, even though they refer to the same type. It's probably intentional somewhere in the compiler that this happens becausereadonlysupport is real real complex in the compiler.