Skip to content

@W-18182827 fix: added changes for preview without specifying component name #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

pulkit0555
Copy link
Contributor

What does this PR do?

[CLI] Support launching without specifying a component

What issues does this PR fix or reference?

@W-18182827@

@pulkit0555 pulkit0555 requested review from a team as code owners May 1, 2025 20:18
@pulkit0555 pulkit0555 self-assigned this May 1, 2025
@@ -79,12 +78,6 @@ export default class LightningDevComponent extends SfCommand<void> {
}

name = match.name;
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be removed.... In the previous release we added the ability to use prompts and ask the user for values to different option flags. This applied to app, site, and component commands and was part of the user experience.

Basically the user should be able to just run sf lightning dev and interactively be asked a series of questions to determine what the user wants to do. Of course the user has the option of running sf lightning dev blah blah and provide the flag values but if they choose not to provide anything and just run sf lightning dev then the interactive experience should take over.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we saying that we will continue to have the interactive behavior for all other commands/parameters and only for this one we decide not to ask for its value b/c the user can instead just pick it from the menu after single component preview interface loads up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants