FiniteWriter trait + many important fixes #11
Conversation
|
|
||
| impl FiniteWriter for io::MemWriter {} | ||
| impl FiniteWriter for io::stdio::StdWriter {} | ||
| impl<W: Writer> FiniteWriter for io::BufferedWriter<W> {} |
There was a problem hiding this comment.
The indentation in this file is a little off, and I'm not sure that this is the best way to go about this. This trait seems very specific and I don't understand why you have FiniteWriter implementations for various writers, but not various other writers.
Can you explain a little more about why this is necessary? Is this purely because you can't call generic methods from destructors?
There was a problem hiding this comment.
Sorry about the tabs, I should be more careful when coding at night.
The implementations here are for the things that we actually use in rust-compress. Ideally, we'd want it to be implemented by default on every Writer, and just write specialization implementations for things like ~FiniteWriter. AFAIK, there is no analogue of C++ template specialization in Rust, is there?
Yes, that code was required in order to work around the destructor limitations. I'm not an IO guru, so any insights from you would be very welcome.
|
OK, I fixed what I could (Ari tests, shared exposure and tabs). Let me know if there is anything else you'd like to see differently. |
|
I've come to think that |
|
Ok, fair enough. |
|
BWT and Ari fixes are submitted in PR #12 |
FiniteWriteris now implemented for everyWriter, and used by the test app to terminate the stream properly.BWT decoding is now fixed.
Ari
ByteDecoderdoesn't need to know the output size any more, enabled for the test app.