test-runner: Simplify and slightly refactor the disk test #641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per rust-osdev#553, we've made the test runner always expect to be running in the special QEMU env, so we don't need to have a separate "works with any env" disk test from the more detailed "known disk" test. So, move `known_disk.rs` -> `mod.rs`.
Simplify the big disk test function a little by moving the loop to find the test disk into a new function.
This is just one file now, so move `media/mod.rs` -> `media.rs`.
phip1611
force-pushed
the
bishop-disk-test-updates
branch
from
e4b97fa to
8f579a6
Compare
phip1611
approved these changes
Jan 22, 2023
|
good cleanup, nice work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #553, we've made the test runner always expect to be running in the special QEMU env, so we don't need to have a separate "works with any env" disk test from the more detailed "known disk" test. So, collapse the
media/{mod.rs, known_disk.rs}directory to justmedia.rs.Also simplify the big disk test function a little by moving the loop to find the test disk into a new function.
Should be no functional change to what is being tested, just a little easier to read now.
Checklist