uefi-test-runner: Assume that we're running in the special QEMU env #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasbishop
force-pushed
the
bishop-runner-just-qemu-4
branch
2 times, most recently
from
c46a09d to
c586d88
Compare
phip1611
reviewed
Nov 20, 2022
We now assume that the app is always running in QEMU, so this doesn't need to be conditional.
nicholasbishop
force-pushed
the
bishop-runner-just-qemu-4
branch
from
c586d88 to
8e673f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes care of some of the low-hanging fruit for #553:
qemufeature fromuefi-test-runner, since we always want that behavior now.In a future PR I'll do some more cleanups like changing warn/error logs to asserts, but this will require some care because the supported protocols are a bit different between x86 and arm.
Checklist