Skip to content

cleanup IPConfig2/Http Protocol #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

cleanup IPConfig2/Http Protocol #1640

merged 1 commit into from
May 19, 2025

Conversation

phip1611
Copy link
Member

Follow-up of #1614 by @kraxel.

  • missing file in .gitignore

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611 phip1611 requested a review from nicholasbishop April 19, 2025 10:11
@phip1611
Copy link
Member Author

phip1611 commented Apr 19, 2025

I never see any output in the OVMF debugcon log file. Did this ever work? @kraxel

I've also noticed that the SNP test can't run after the HTTP test. I think we missed proper cleanup in the Http integration test to reach idempotence. This can be investigated after #1621 is merged.

@nicholasbishop
Copy link
Member

nicholasbishop commented Apr 19, 2025

I never see any output in the OVMF debugcon log file.

It depends on how OVMF is built: https://github.com/tianocore/edk2/blob/62390a89c5eb477594b74b5e1911d65998a8abe2/OvmfPkg/README#L90

Currently, ovmf-prebuilt uses the RELEASE build target, so there's no debug output if you run with the prebuilts: https://github.com/rust-osdev/ovmf-prebuilt/blob/main/build-edk2/Dockerfile

@phip1611 phip1611 changed the title xxx: cleanup IPConfig2/Http Protocol cleanup IPConfig2/Http Protocol Apr 19, 2025
@phip1611
Copy link
Member Author

Ready for merge

@nicholasbishop nicholasbishop enabled auto-merge May 19, 2025 20:17
@nicholasbishop nicholasbishop added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit b171db7 May 19, 2025
20 checks passed
@nicholasbishop nicholasbishop deleted the cleanup branch May 19, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants