Skip to content

Suggest single-axis slicing methods for generic fns #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

jturner314
Copy link
Member

This makes the single-axis slicing methods more easily discoverable and illustrates why they're especially useful in generic code.

This makes the single-axis slicing methods more easily discoverable
and illustrates why they're especially useful in generic code.
@bluss
Copy link
Member

bluss commented Feb 5, 2021

This makes sense. Would it also be good to add a helper method for this - like slice_each_axis_inplace(f: impl FnMut(AxisDescription) -> Slice) that makes it even more accessible?

@jturner314
Copy link
Member Author

This makes sense. Would it also be good to add a helper method for this - like slice_each_axis_inplace(f: impl FnMut(AxisDescription) -> Slice) that makes it even more accessible?

Yeah, that seems like a good idea. I've created #913 to replace this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants