Change type of end field in slices to Bound #480
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just noticed the
Bound
enum in the standard library while I was reading about the newRangeBounds
trait. I thought I'd propose switching to theBound
type, now that we have support for inclusive ranges (#467). There is no memory cost to doing this (sinceBound<isize>
andOption<isize>
are the same size). This is a breaking change.I'm pretty ambivalent about this PR, since
Option
has the benefit of being more common thanBound
and having lots of convenient methods. It's also nice to only have to deal with exclusive end bounds after theSlice
/SliceOrIndex
is created. So, I'm curious to see what everyone thinks about this change.