Skip to content

Rename *_mut to *_inplace to match ndarray #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

jturner314
Copy link
Member

This implements the renaming portion of #83.

In ndarray, *_mut methods return mutable views or references to the contents of the array, while *_inplace methods actually modify data in-place. This PR renames the ndarray-linalg methods to match that convention.

For the trait names, I used *Inplace to match the snake-case method names, although I can change them to *InPlace if you prefer.

@termoshtt termoshtt merged commit 3d0dfa8 into rust-ndarray:master Sep 28, 2017
@jturner314 jturner314 deleted the rename-mut-inplace branch September 28, 2017 14:11
@termoshtt termoshtt added this to the v0.7.0 milestone Oct 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants