Rename *_mut to *_inplace to match ndarray #84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the renaming portion of #83.
In
ndarray
,*_mut
methods return mutable views or references to the contents of the array, while*_inplace
methods actually modify data in-place. This PR renames thendarray-linalg
methods to match that convention.For the trait names, I used
*Inplace
to match the snake-case method names, although I can change them to*InPlace
if you prefer.