This repository was archived by the owner on Nov 18, 2022. It is now read-only.
Bump required VSCode version and use LSP 3.15 #790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason for this bump is to pull in
vscode-languageclient@^6.0, which implements LSP 3.15, most notably new progress API and other goodies such as diagnostics with deprecated tag.Since rust-analyzer pushes the envelope wrt LSP and uses proposed/cutting edge features, we should land this before offering the switch not to regress anything major when compared to the rust-analyzer VSCode extension.
Refs: #780