Skip to content

Give types team members access to perf, crater and dev-desktops. #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Give types team members access to perf, crater and dev-desktops. #963

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d6346fd
Set aliemjay's zulip id
oli-obk Mar 20, 2023
b7604e0
Give types team members access to perf, crater and dev-desktops.
oli-obk Mar 20, 2023
15b70e2
Add review permissions for types team members
oli-obk Mar 28, 2023
2662cc4
try is implied by review
oli-obk Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions people/aliemjay.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ name = "Ali MJ Al-Nasrawy"
github = "aliemjay"
github-id = 28497461
email = "[email protected]"
zulip-id = 430838
4 changes: 4 additions & 0 deletions teams/types.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,3 +39,7 @@ extra-people = ["eholk"]

[permissions]
bors.chalk.review = true
bors.rust.try = true
perf = true
crater = true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crater runs don't happen super often. Given that they take a large amount of expensive machinery to run it seems reasonable to limit its use. Is there any reason the types team members can't reach out to a compiler team member when this is needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crater runs don't happen super often

Types team members run crater far more frequently than most other compiler contributors.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds find to me. cc @Mark-Simulacrum and @pietroalbini

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with types having crater access.

dev-desktop = true