Skip to content

Leave the Rustdoc team #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 8, 2022

I don't want to keep up with FCPs and I also don't want to block them (@Manishearth has suggested a few times that the minimum work required for being a member is "responding to FCPs in a timely manner").

Additionally, I don't want people to assign me on PRs.

I don't want to keep up with FCPs and I also don't want to block them
(@Manishearth has suggested a few times that the minimum work required for being a member is
"responding to FCPs in a timely manner").

Additionally, I don't want people to assign me on PRs.
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be sad to see you go, hopefully we still see you around!

I will point out that the thing I mentioned about FCPs was largely for normal team members: I do think it's acceptable for team leads to focus on leadership and defer on FCPs/etc. But it does sound like you're not that interested in continuing, that's fine too. Feel free to reach out if you want to talk about it!

@GuillaumeGomez
Copy link
Member

I'm sad that you're leaving us too... Thanks to you, rustdoc situation improved a lot. Hopefully, we will see you around.

@jsha
Copy link

jsha commented Jan 8, 2022

Thanks for all you've done! You really helped me feel welcomed onto the team when I first started making contributions, so thank you for that in particular.

@camelid
Copy link
Member

camelid commented Jan 8, 2022

Thank you for mentoring me as I started contributing and continuing onward, for many fun discussions about how to improve rustdoc, for helping me to learn PR review, and for many other things. It's been a lot of fun the last couple of years!

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rylev rylev merged commit fd6bd13 into rust-lang:master Jan 10, 2022
@jyn514 jyn514 deleted the so-long-and-thanks-for-all-the-fish branch January 10, 2022 15:30
@willcrichton
Copy link

Thanks @jyn514!! You're the reason I was able to get --scrape-examples off the ground and on nightly.

@0xPoe
Copy link
Member

0xPoe commented Jan 11, 2022

I have received many comments and help with my PR from you in the past and you are always so patient and enthusiastic. Thank you so much! @jyn514

@janriemer
Copy link

I remember my first PR for Rust where you've responded to my questions so quickly, it was almost scary. 😄
Speaking of scary: In the PR there was a situation, where the ghost emoji disappeared by accident. 👻 Fortunately, we could add it back in. 😌 Now, you are leaving the Rustdoc team, but... maybe you will come back in the future, just like the ghost emoji did (at least, that's what I hope)!? 🥲

Thank you, @jyn514, for all you have done for the Rust community and rustdoc. ❤️ I wish you all the best on your future journey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants