Skip to content

Add back branch protection for expect-test #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented May 29, 2025

The expect-test repo had quite weird branch protections (#1805): both pr-required = false and non-empty ci-checks. In #1805, I removed the CI check, but I think it actually makes more sense to require PRs and the CI check, unless someone asks for the opposite.

@Kobzol Kobzol requested a review from marcoieni May 29, 2025 14:51
Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-analyzer/expect-test':
      Branch Protections:
          master
            Required Approving Review Count: 0 => 1
            Requires PR: false => true
            Required Checks: [] => ["test"]

@marcoieni marcoieni added this pull request to the merge queue May 30, 2025
Merged via the queue into rust-lang:master with commit a1af885 May 30, 2025
3 checks passed
@Kobzol Kobzol deleted the expect-test-branch-protection branch May 30, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants