std_detect: Do not use libc::getauxval on 32-bit Android #1421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libc crate currently doesn't provide it.
|
r? @Amanieu (rustbot has picked a reviewer for you, use r? to override) |
taiki-e
force-pushed
the
android-getauxval
branch
from
8f48850 to
e2b3cd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the build error in rust-lang/rust#110285 (comment).
In #1406 I checked only aarch64 android and missed the fact that libc crate does not provide getauxval on 32-bit android (although I believe android provides getauxval on these targets). Sorry.
The second commit in this PR adds a job to CI that builds non-Linux targets that are not currently tested in CI to prevent such an oversight from occurring again in the future.