Better error when a ValueValidation error occurs #3310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xPoe
changed the title
0xPoe
commented
Apr 4, 2023
|
The test shows nice behaviour. It seems like clap has some way to go to make this have a really nice interface. |
Signed-off-by: hi-rustin <[email protected]>
0xPoe
force-pushed
the
rustin-patch-help
branch
2 times, most recently
from
fafbbd6 to
5e5b53e
Compare
0xPoe
changed the title
Signed-off-by: hi-rustin <[email protected]>
I changed it again. Because the help text in this commit is still not very user-friendly. Because it does not show the value which the user passed to the rustup. Also, I think print help text for users is not consistent with other errors. So I prefer to just tell the users why we print the |
rbtcollins
reviewed
Apr 4, 2023
Signed-off-by: hi-rustin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another solution for clap-rs/clap#4799
See clap-rs/clap#4799 (reply in thread)