Skip to content

Write non-output to stderr when there is output #859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 13, 2016

Conversation

solidsnack
Copy link
Contributor

This allows one to redirect checkstyle and diff output directly to a file.

:;  cargo fmt -- --write-mode checkstyle > xml.xml
Using rustfmt config file /Users/solidsnack/sandbox/jsoncdc/rustfmt.toml for /Users/solidsnack/sandbox/jsoncdc/src/lib.rs

@@ -213,7 +222,7 @@ fn execute() -> i32 {
for {}",
file.display()));
if let Some(path) = path_tmp.as_ref() {
println!("Using rustfmt config file {} for {}",
msg!("Using rustfmt config file {} for {}",
path.display(),
file.display());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to fix the alignment here to pass the tests

@nrc
Copy link
Member

nrc commented Mar 9, 2016

r+ with the test passing

@solidsnack
Copy link
Contributor Author

Not formatting my patch to rustfmt... ¬_¬

@solidsnack
Copy link
Contributor Author

An update to syntex_syntax led to a panic! when parsing the macro in src/bin/rustfmt.rs. Apparently the new version does not like the macro syntax with parens. This could lead to a regression.

nrc added a commit that referenced this pull request Mar 13, 2016
Write non-output to stderr when there is output
@nrc nrc merged commit 17856e8 into rust-lang:master Mar 13, 2016
@nrc
Copy link
Member

nrc commented Mar 13, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants