Use trait to abstract emit modes #3616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 16 commits
June 10, 2019 17:11
This reverts commit da1e73c.
bash
changed the title
topecongiro
reviewed
Jun 12, 2019
src/lib.rs
Outdated
| @@ -469,10 +474,23 @@ impl<'b, T: Write + 'b> Session<'b, T> { | |||
| } | |||
| } | |||
|
|
|||
| pub(crate) fn create_emitter<'a>(config: &Config) -> Box<dyn Emitter + 'a> { | |||
| match config.emit_mode() { | |||
| EmitMode::Files if config.make_backup() => Box::new(emitter::FilesWithBackupEmitter::new()), | |||
There was a problem hiding this comment.
I prefer to use default() over an empty constructor.
src/test/mod.rs
Outdated
| #[cfg(windows)] | ||
| assert_eq!(buf, "fn main() {}\r\n".as_bytes()); | ||
| assert_eq!(buf, "stdin:\n\r\nfn main() {}\r\n".as_bytes()); |
There was a problem hiding this comment.
writeln! only emits the line feed character [1], so the first \r is unnecessary here.
There was a problem hiding this comment.
That explains why the windows build was failing 😄. Thanks.
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.