Skip to content

Fixing straightforward configuration snippets (Part 2) #2395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jan 29, 2018

Conversation

davidalber
Copy link
Contributor

This is the second -- and final -- batch of straightforward configuration snippet fixes for #1845. See #2369 for the first batch.

As in the previous PR, the fixes use a few approaches. Most commonly, snippets are wrapped in a function and lines are made longer to reach the default max width, which often triggers formatting.

This batch corrects sixteen configuration snippets, as can be seen with cargo test -- --ignored. Here is the output on master:

---- configuration_snippet_tests stdout ----
        Ran 104 configurations tests.
thread 'configuration_snippet_tests' panicked at 'assertion failed: `(left == right)`
  left: `22`,
 right: `0`: 22 configurations tests failed', tests/system.rs:800:5

Here is the output on the PR branch:

---- configuration_snippet_tests stdout ----
        Ran 104 configurations tests.
thread 'configuration_snippet_tests' panicked at 'assertion failed: `(left == right)`
  left: `6`,
 right: `0`: 6 configurations tests failed', tests/system.rs:800:5

The fixes for the remaining six failing cases will be more involved or require more discussion, so they will arrive in separate PRs.

@nrc nrc merged commit ba3dec2 into rust-lang:master Jan 29, 2018
@nrc
Copy link
Member

nrc commented Jan 29, 2018

Thank you! It's great to see this project unfolding over so many PRs!

@davidalber davidalber deleted the fix-configuration-snippets2 branch February 3, 2018 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants