Add rudimentary timing of parsing and formatting phases #2149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was interested to see how much time is spent parsing vs formatting. This adds a timer to
Summary
to measure these things.When run on rustfmt itself, using
$ cargo run --release --bin rustfmt -- --verbose src/lib.rs
, I get the following results on my machine:In this case, formatting takes about 4x as long as parsing. This suggests that it should be worthwhile to look into trimming the fat from rustfmt.
cc #338