Skip to content

Use correct spans when rewrting attributes #1669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 13, 2017

Conversation

topecongiro
Copy link
Contributor

This PR

  1. add changes to prevent rustfmf to overflow arithmetic when running tests.
  2. try to use correct spans when rewriting attributes. The span of ast::Expr does not cover its attributes, and the span of ast::MetaItem is missing closing parens.

@nrc nrc merged commit 8a33521 into rust-lang:master Jun 13, 2017
@nrc
Copy link
Member

nrc commented Jun 13, 2017

I would like to makes sure we fix this in libsyntax and then remove this fix from the rustfmt code - i.e., ensure that it stays temporary. Probably the best way to do that is file an issue here and add the issue number to the FIXME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants