assert!() macro's formatting is unlike anything else #3550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

CryZe opened this issue May 14, 2019 · 0 comments · Fixed by #4189

Labels

a-macros poor-formatting

CryZe commented May 14, 2019

For some reason the assert!() macro is not following the normal formatting rules:

component is not on a new line and the final ); isn't either. Here's the playground repro by shepmaster: https://play.integer32.com/?version=stable&mode=debug&edition=2018&gist=ffd800255272b66f60170a907f1bc8e2

topecongiro added a-macros poor-formatting labels

ayazhafiz added a commit to ayazhafiz/rustfmt that referenced this issue


          Add test cases for fixed issues

00b2470

The cases with `hard_tabs: true` were fixed in 2836f9b.
Not sure about the rest, but this suggests a number of open issues are
already resolved.

Closes rust-lang#3608
Closes rust-lang#3550
Closes rust-lang#3638
Closes rust-lang#3858
Closes rust-lang#3936

ayazhafiz mentioned this issue

Add test cases for fixed issues #4189

Merged

ayazhafiz added a commit to ayazhafiz/rustfmt that referenced this issue


          Add test cases for fixed issues

aac7f91

The cases with `hard_tabs: true` were fixed in 2836f9b.
Not sure about the rest, but this suggests a number of open issues are
already resolved.

Closes rust-lang#3608
Closes rust-lang#3550
Closes rust-lang#3638
Closes rust-lang#3858
Closes rust-lang#3936

topecongiro closed this as completed in #4189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment