Run other types of tests like run-make

[antoyo]

run-make is a testsuite from the Rust repo.

There are other tests from the Rust testsuite that we could run as well.

It probably needs to be done in a similar way to how we do the UI tests.

[lordshashank]

@antoyo could you explain this a bit more?
From what I understand you want something like

fn run_make_tests(env: &Env, args: &TestArg) -> Result<(), String> {
    let path = Path::new(crate::BUILD_DIR).join("run-make");
    run_cargo_command(&[&"clean"], Some(&path), env, args)?;
    println!("[TEST] run-make");
    run_cargo_command(&[&"test", &"--workspace"], Some(&path), env, args)?;
    Ok(())
}

in build_system ?

[antoyo]

@lordshashank: No. I added a description to the post. Feel free to ask questions if you need to.

[lordshashank]

@antoyo facing build error 😓. So I followed instructions and built gcc from your fork with default config.toml and got following error on running cargo build at parent directory

/usr/bin/ld: cannot find -lgccjit: No such file or directory
          collect2: error: ld returned 1 exit status

I installed libgccjit using apt-get and exported LD_LIBRARY_PATH as well, still same error.
location of my libgccjit is /usr/lib/gcc/x86_64-linux-gnu/10/libgccjit.so and running ld -lgccjit --verbose gives me following output

ld: mode elf_x86_64
attempt to open /usr/local/lib/x86_64-linux-gnu/libgccjit.so failed
attempt to open /usr/local/lib/x86_64-linux-gnu/libgccjit.a failed
attempt to open /lib/x86_64-linux-gnu/libgccjit.so failed
attempt to open /lib/x86_64-linux-gnu/libgccjit.a failed
attempt to open /usr/lib/x86_64-linux-gnu/libgccjit.so failed
attempt to open /usr/lib/x86_64-linux-gnu/libgccjit.a failed
attempt to open /usr/lib/x86_64-linux-gnu64/libgccjit.so failed
attempt to open /usr/lib/x86_64-linux-gnu64/libgccjit.a failed
attempt to open /usr/local/lib64/libgccjit.so failed
attempt to open /usr/local/lib64/libgccjit.a failed
attempt to open /lib64/libgccjit.so failed
attempt to open /lib64/libgccjit.a failed
attempt to open /usr/lib64/libgccjit.so failed
attempt to open /usr/lib64/libgccjit.a failed
attempt to open /usr/local/lib/libgccjit.so failed
attempt to open /usr/local/lib/libgccjit.a failed
attempt to open /lib/libgccjit.so failed
attempt to open /lib/libgccjit.a failed
attempt to open /usr/lib/libgccjit.so failed
attempt to open /usr/lib/libgccjit.a failed
attempt to open /usr/x86_64-linux-gnu/lib64/libgccjit.so failed
attempt to open /usr/x86_64-linux-gnu/lib64/libgccjit.a failed
attempt to open /usr/x86_64-linux-gnu/lib/libgccjit.so failed
attempt to open /usr/x86_64-linux-gnu/lib/libgccjit.a failed
ld: cannot find -lgccjit: No such file or directory
attempt to open /usr/local/lib/x86_64-linux-gnu/libgccjit.so failed
attempt to open /usr/local/lib/x86_64-linux-gnu/gccjit.a failed
attempt to open /lib/x86_64-linux-gnu/libgccjit.so failed
attempt to open /lib/x86_64-linux-gnu/gccjit.a failed
attempt to open /usr/lib/x86_64-linux-gnu/libgccjit.so failed
attempt to open /usr/lib/x86_64-linux-gnu/gccjit.a failed
attempt to open /usr/lib/x86_64-linux-gnu64/libgccjit.so failed
attempt to open /usr/lib/x86_64-linux-gnu64/gccjit.a failed
attempt to open /usr/local/lib64/libgccjit.so failed
attempt to open /usr/local/lib64/gccjit.a failed
attempt to open /lib64/libgccjit.so failed
attempt to open /lib64/gccjit.a failed
attempt to open /usr/lib64/libgccjit.so failed
attempt to open /usr/lib64/gccjit.a failed
attempt to open /usr/local/lib/libgccjit.so failed
attempt to open /usr/local/lib/gccjit.a failed
attempt to open /lib/libgccjit.so failed
attempt to open /lib/gccjit.a failed
attempt to open /usr/lib/libgccjit.so failed
attempt to open /usr/lib/gccjit.a failed
attempt to open /usr/x86_64-linux-gnu/lib64/libgccjit.so failed
attempt to open /usr/x86_64-linux-gnu/lib64/gccjit.a failed
attempt to open /usr/x86_64-linux-gnu/lib/libgccjit.so failed
attempt to open /usr/x86_64-linux-gnu/lib/gccjit.a failed

Could you please help on what the issue could be?

[antoyo]

You need to use our custom build system to build rustc_codegen_gcc, so issue this command instead of cargo build:

./y.sh build

[lordshashank]

ya, already tried that getting same error with download-gccjit commented and if uncommented, I get following error.

[lordshashank]

Ok so I tried again this morning and now everything is working, thanks.