Use updated local declaration syntax for xfail'd test #9982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danluu: Mozilla doesn't require copyright assignment for contributors, but you do need the ability to license the code under the dual license Rust uses. |
|
Yes, that's fine. AFAIK, there aren't any limitations on the license, once you get approval to submit a patch (which I did). Thanks for the info! |
bors
added a commit
that referenced
this pull request
Oct 21, 2013
This patch is trivial, but it comes with a question. Does Mozilla need to own the copyright on code submitted to Rust? The reason I ask is that, since the last time I submitted anything to a Mozilla project, I started working at Google, and they (by default) own the copyright on code that I write (even in my spare time). There's a process to assign copyright to another entity, and it should be a formality for something like this, but I'd still have to go through it if that's a requirement for Rust. Anyway, I'm submitting this incredibly trivial thing because, if I have to go through that process for the first time, I'd like it to be for something that's trivial, so I can see how much of a hassle it is (if any) without having invested much time up front. I didn't see anything about copyright in the Mozilla contributor's agreement, but I could have easily missed something somewhere else.
|
@danluu: Ah, this ran into one of the obscure Windows test suite errors. It will work if you mark the |
|
@danluu Thanks! 🌷 |
bors
added a commit
that referenced
this pull request
Oct 22, 2013
This patch is trivial, but it comes with a question. Does Mozilla need to own the copyright on code submitted to Rust? The reason I ask is that, since the last time I submitted anything to a Mozilla project, I started working at Google, and they (by default) own the copyright on code that I write (even in my spare time). There's a process to assign copyright to another entity, and it should be a formality for something like this, but I'd still have to go through it if that's a requirement for Rust. Anyway, I'm submitting this incredibly trivial thing because, if I have to go through that process for the first time, I'd like it to be for something that's trivial, so I can see how much of a hassle it is (if any) without having invested much time up front. I didn't see anything about copyright in the Mozilla contributor's agreement, but I could have easily missed something somewhere else.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 17, 2022
Don't lint `from_over_into` for opaque types fixes rust-lang#9935 This is stalled until the next sync. The impl in question can't be written on the pinned nightly. changelog: Don't lint `from_over_into` for opaque types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is trivial, but it comes with a question. Does Mozilla need to own the copyright on code submitted to Rust?
The reason I ask is that, since the last time I submitted anything to a Mozilla project, I started working at Google, and they (by default) own the copyright on code that I write (even in my spare time). There's a process to assign copyright to another entity, and it should be a formality for something like this, but I'd still have to go through it if that's a requirement for Rust.
Anyway, I'm submitting this incredibly trivial thing because, if I have to go through that process for the first time, I'd like it to be for something that's trivial, so I can see how much of a hassle it is (if any) without having invested much time up front.
I didn't see anything about copyright in the Mozilla contributor's agreement, but I could have easily missed something somewhere else.