Skip to content

Use relative links instead of linking to doc.rust-lang.org when possible #97940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2022
Merged

Use relative links instead of linking to doc.rust-lang.org when possible #97940

merged 1 commit into from
Jun 11, 2022

Conversation

GuillaumeGomez
Copy link
Member

Part of #97918.

@GuillaumeGomez GuillaumeGomez added the A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools label Jun 10, 2022
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jun 10, 2022
@rust-highfive
Copy link
Contributor

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 10, 2022
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 10, 2022
Closed
@Dylan-DPC
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 10, 2022

📌 Commit 28ca3bd has been approved by Dylan-DPC

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 10, 2022
@Dylan-DPC
Rollup merge of rust-lang#97940 - GuillaumeGomez:relative-link, r=Dyl…
345e067 
…an-DPC

Use relative links instead of linking to doc.rust-lang.org when possible

Part of rust-lang#97918.
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 10, 2022
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 10, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2022
@bors
Auto merge of rust-lang#97968 - matthiaskrgr:rollup-qtd4i5h, r=matthi…
b9f3bdf 
…askrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#93331 (refactor write_output_file to merge two invocation paths into one.)
 - rust-lang#97928 (Removes debug settings from wasm32_unknown_emscripten default link args)
 - rust-lang#97940 (Use relative links instead of linking to doc.rust-lang.org when possible)
 - rust-lang#97941 (nit: Fixed several error_codes/Exxxx.md messages which used UpperCamelCase…)
 - rust-lang#97953 (Add regression test for rust-lang#54378)
 - rust-lang#97957 (Make `std::` prefix suggestion test `run-rustfix`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 30a8903 into rust-lang:master Jun 11, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 11, 2022
@GuillaumeGomez GuillaumeGomez deleted the relative-link branch June 11, 2022 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
6 participants
@GuillaumeGomez @rust-highfive @Dylan-DPC @bors @joshtriplett @rustbot