Fix for Issue 89275 #89569
Closed
Fix for Issue 89275 #89569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Issue 89275 fix and test Fix librustdoc OverflowError usage rust tidy run Issue 89275 fix and test
tom7980
force-pushed
the
issue-89275-fix
branch
from
e44f6f1 to
fc0d63d
Compare
|
I need to sort out my commits first - seem to have ended up in an extremely complicated place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #89275 and potentially #77291 #75397
The problem of error reporting iterating over ambiguous traits and emitting a recursion limit error message on the initial mismatched type error.
I updated the OverflowError type from a struct to an enum so I believe it is no longer a ZST - I don't think this should cause any issue as it should only be constructed if you actually cause a recursion error in type checking or in this case where there's an ambiguous trait in scope that it checks for a conversion method.