Skip to content

Make concrete_opaque_types be FxHashSet<DefId> #87927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

spastorino
Copy link
Member

r? @oli-obk

@bors rollup=always

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 10, 2021
@spastorino spastorino closed this Aug 10, 2021
@spastorino spastorino reopened this Aug 10, 2021
@spastorino spastorino force-pushed the use-def-id-typeckresults branch from 11f285e to 0aa0d59 Compare August 11, 2021 12:48
@oli-obk
Copy link
Contributor

oli-obk commented Aug 11, 2021

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 11, 2021

📌 Commit 0aa0d59 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2021
@spastorino
Copy link
Member Author

@bors rollup=always

@bjorn3
Copy link
Member

bjorn3 commented Aug 11, 2021

This will affect performance, right? Shouldn't it be rollup=never?

@oli-obk
Copy link
Contributor

oli-obk commented Aug 11, 2021

i find it unlikely to affect perf, but let's check

@bors rollup=never

@bors
Copy link
Collaborator

bors commented Aug 11, 2021

⌛ Testing commit 0aa0d59 with merge 25e343745e673f6b6406df468d65b15d0724c187...

@bors
Copy link
Collaborator

bors commented Aug 12, 2021

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 12, 2021
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@spastorino
Copy link
Member Author

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2021
@bors
Copy link
Collaborator

bors commented Aug 13, 2021

⌛ Testing commit 0aa0d59 with merge 13d6c5c...

@bors
Copy link
Collaborator

bors commented Aug 13, 2021

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing 13d6c5c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 13, 2021
@bors bors merged commit 13d6c5c into rust-lang:master Aug 13, 2021
@rustbot rustbot added this to the 1.56.0 milestone Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants