The RtioTimer trait should not be exposed to the outside world. #8691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @brson |
bors
added a commit
that referenced
this pull request
Aug 23, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Apr 21, 2022
…cursion, r=llogiq Prevent infinite (exponential) recursion in only_used_in_recursion This simplifies the visitor code a bit and prevents checking expressions multiple times. I still think this lint should be removed for now, because its code isn't really tested. Fixes rust-lang#8689 **NOTE:** Before merging this, we should talk about removing and revisiting this lint. See my comment in rust-lang#8689 changelog: prevent infinite recursion in [`only_used_in_recursion`]
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 5, 2022
Move only_used_in_recursion to nursery r? `@llogiq` I still think this is the right thing to do for this lint. See: rust-lang#8782 I want to get this merged before the sync on Thursday, because I want to backport this and the last fix rust-lang#8691 to beta. changelog: Move [`only_used_in_recursion`] to nursery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8687.