Pass struct types by pointer, drop arguments in the caller #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we lose tail calls, this is possible. It simplifies things a lot. Direct motivation: We want ivecs with pointers pointing into themselves. When copying those, the pointers have to be adjusted. It is impossible to this when copying them with Load/Store.
This makes it easier for the caller to optimize the take/drop away for temporary values, and opens up new possibilities for alias handling. Breaks tail calls.
|
Integrated. |
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
Separate and Update Fuchsia The first commit pulls Fuchsia out into its own directory, while the second commit updates the "open" flags as in rust-lang#848. cc @smklein, @alexcrichton
ZuseZ4
pushed a commit
to EnzymeAD/rust
that referenced
this pull request
Mar 7, 2023
* Add atomic fadd for reverse mode * Fix lower version * Fix for version * add maybealign
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
…e CBMC output parser (rust-lang#849)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first nail in the coffin of tail calls. It passes all tests, but I don't want to land it right away because some people might still believe in tail calls. So if you object, speak now or forever hold your peace. If no discussion is forthcoming (I'll post a heads-up on the mailing list), I'll merge this myself in a few days.