Skip to content

std::io: Use sendfile for UnixStream #79600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 2, 2020
Merged

std::io: Use sendfile for UnixStream #79600

merged 2 commits into from
Dec 2, 2020

Conversation

nicokoch
Copy link
Contributor

@nicokoch nicokoch commented Dec 1, 2020

UnixStream was forgotten in #75272 .

Benchmark yields the following results.
Before:
running 1 test test sys::unix::kernel_copy::tests::bench_file_to_uds_copy ... bench: 54,399 ns/iter (+/- 6,817) = 2409 MB/s

After:
running 1 test test sys::unix::kernel_copy::tests::bench_file_to_uds_copy ... bench: 18,627 ns/iter (+/- 6,007) = 7036 MB/s

@nicokoch
Add benchmark for File to UnixStream copy
eda4c63
@nicokoch
Leverage kernel copy for UnixStream
5987451 
UDS can be a sendfile destination, just like TCP sockets.
@rust-highfive
Copy link
Contributor

r? @m-ou-se

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 1, 2020
@m-ou-se m-ou-se added A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` T-libs Relevant to the library team, which will review and decide on the PR/issue. O-linux Operating system: Linux labels Dec 1, 2020
@m-ou-se
Copy link
Member

m-ou-se commented Dec 1, 2020

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 1, 2020

📌 Commit 5987451 has been approved by m-ou-se

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 1, 2020
@GuillaumeGomez GuillaumeGomez mentioned this pull request Dec 1, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 1, 2020
@bors
Auto merge of rust-lang#79614 - GuillaumeGomez:rollup-15usd7e, r=Guil…
18aa5ee 
…laumeGomez

Rollup of 3 pull requests

Successful merges:

 - rust-lang#79508 (Warn if `dsymutil` returns an error code)
 - rust-lang#79509 (Improve attribute message error spans)
 - rust-lang#79600 (std::io: Use sendfile for UnixStream)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 9e26fc6 into rust-lang:master Dec 2, 2020
@rustbot rustbot added this to the 1.50.0 milestone Dec 2, 2020
@nicokoch nicokoch deleted the kernel_copy_unixstream branch December 2, 2020 22:19
@the8472 the8472 mentioned this pull request Dec 2, 2020
Merged
@nicokoch
Copy link
Contributor Author

nicokoch commented Dec 4, 2020

@the8472 I also noticed CopyRead and CopyWrite are not implemented for Box<T> where T: Copy{Read|Write}. Is this deliberate or an oversight?

@the8472
Copy link
Member

the8472 commented Dec 4, 2020

I assumed that is handled by auto-deref. If it isn't then it should be added.

@nicokoch
Copy link
Contributor Author

nicokoch commented Dec 4, 2020

I'm not entirely sure, will have to test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@m-ou-se m-ou-se

Labels
A-io Area: `std::io`, `std::fs`, `std::net` and `std::path` O-linux Operating system: Linux S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.50.0
Development

Successfully merging this pull request may close these issues.
6 participants
@nicokoch @rust-highfive @m-ou-se @bors @the8472 @rustbot