Code

fix a couple of clippy findings#75270

Code

Merged

bors merged 17 commits intorust-lang:masterrust-lang/rust:masterfrom

matthiaskrgr:clippy_aug_1matthiaskrgr/rust:clippy_aug_1Copy head branch name to clipboard

Aug 8, 2020

Commits

Commits on Aug 7, 2020

• fix clippy::expect_fun_call: use unwrap_or_else to prevent panic message from always being evaluated

  matthiaskrgr

  committed
  3ef8c72

  Copy full SHA for 3ef8c72

• fix clippy::filter_next: use .find(..) instead of .filter(..).next()

  matthiaskrgr

  committed
  8bc1f91

  Copy full SHA for 8bc1f91

• fix clippy::iter_next_slice: use .get(0) instead of .iter().next()

  matthiaskrgr

  committed
  fca81fa

  Copy full SHA for fca81fa

• fix clippy::map_identity: remove redundant .map(|x| x) call

  matthiaskrgr

  committed
  fb975cd

  Copy full SHA for fb975cd

• fix clippy::redundant_clone: remove redundant clones

  matthiaskrgr

  committed
  27bb689

  Copy full SHA for 27bb689

• fix clippy::redundant_pattern_matching: use .is_some() instead of if let Some(_) = ..

  matthiaskrgr

  committed
  09e29e7

  Copy full SHA for 09e29e7

• fix clippy::single_char_pattern: use char instead of string single-char pattern

  matthiaskrgr

  committed
  f3ec5be

  Copy full SHA for f3ec5be

• fix clippy::unit_arg: make it explicit that Ok(()) is being returned

  matthiaskrgr

  committed
  a1c2212

  Copy full SHA for a1c2212

• fix clippy::unnecessary_mut_passed: function arg is not required to be mutable

  matthiaskrgr

  committed
  f6b1857

  Copy full SHA for f6b1857

• fix clippy::unneeded_wildcard_pattern: remove redundant wildcard pattern

  matthiaskrgr

  committed
  eccc2fe

  Copy full SHA for eccc2fe

• fix clippy::len_zero: use is_empty() instead of comparing .len() to zero

  matthiaskrgr

  committed
  057730c

  Copy full SHA for 057730c

• fix clippy::redundant_closure: remove redundant closures and call functions directly

  matthiaskrgr

  committed
  f95cfe5

  Copy full SHA for f95cfe5

• fix clippy::while_let_loop: use while let{} instead of loop { if ... break; }

  matthiaskrgr

  committed
  ea9ccfa

  Copy full SHA for ea9ccfa

• fix clippy::into_iter_on_ref: use .iter() instead of into_iter() on references.

  matthiaskrgr

  committed
  4ba1a19

  Copy full SHA for 4ba1a19

• fix clippy::map_clone: use .cloned() instead of .map(|x| x.clone())

  matthiaskrgr

  committed
  15dcda3

  Copy full SHA for 15dcda3

• fix clippy::clone_on_copy: don't clone types that are copy

  matthiaskrgr

  committed
  ff692ab

  Copy full SHA for ff692ab

• fix clippy::needless_return: remove unneeded return statements

  matthiaskrgr

  committed
  a605e51

  Copy full SHA for a605e51